Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): ng build should produce prod bundle #29136

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@kyliau
Copy link
Member

commented Mar 6, 2019

ng build should produce a bundle that could be readily deployed to
a web server, similar to the behavior of current ng build with
webpack.

Note that in Bazel, there is no ng build for dev bundles. Instead,
users are expected to run ts_devserver.

Closes #28877

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from mgechev Mar 6, 2019

@kyliau kyliau requested a review from angular/tools-bazel as a code owner Mar 6, 2019

@googlebot googlebot added the cla: yes label Mar 6, 2019

fix(bazel): ng build should produce prod bundle
`ng build` should produce a bundle that could be readily deployed to
a web server, similar to the behavior of current `ng build` with
webpack.

Note that in Bazel, there is no `ng build` for dev bundles. Instead,
users are expected to run `ts_devserver`.

Closes #28877

@kyliau kyliau force-pushed the kyliau:ngbuild branch from 0279000 to 7e143ba Mar 6, 2019

@ngbot ngbot bot added this to the needsTriage milestone Mar 6, 2019

@mgechev

mgechev approved these changes Mar 6, 2019

@kara kara closed this in 14ce8a9 Mar 7, 2019

@kyliau kyliau deleted the kyliau:ngbuild branch Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.