Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): add missing binary path for api-extractor #29202

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@alan-agius4
Copy link
Contributor

alan-agius4 commented Mar 9, 2019

api-extractor binary is required for external consumers of ng_module that want to use the bundle_dts flag.

This also sets a different api-exttractor binary to use for ng_module, based if it's internal or external.

@alan-agius4 alan-agius4 requested review from angular/fw-dev-infra as code owners Mar 9, 2019

@googlebot googlebot added the cla: yes label Mar 9, 2019

@ngbot ngbot bot added this to the needsTriage milestone Mar 9, 2019

@alan-agius4 alan-agius4 requested a review from alexeagle Mar 9, 2019

@alan-agius4 alan-agius4 force-pushed the alan-agius4:fix-bazel-api-extractor branch from cf5ed9c to 8b30713 Mar 9, 2019

@alan-agius4 alan-agius4 requested a review from angular/fw-compiler as a code owner Mar 9, 2019

fix(bazel): add missing binary path for api-extractor
`api-extractor` binary is required for external consumers of `ng_module` that want to use the `bundle_dts` flag.

This also sets a different api-exttractor binary to use for ng_module, based if it's internal or external.

@alan-agius4 alan-agius4 force-pushed the alan-agius4:fix-bazel-api-extractor branch from 8b30713 to 4267089 Mar 9, 2019

@alexeagle

This comment has been minimized.

Copy link
Contributor

alexeagle commented Mar 11, 2019

g3 error, FYI
google3/third_party/javascript/angular2/rc/packages/bazel/src/ng_module.bzl:8:1: file ':external.bzl' does not contain symbol 'DEFAULT_API_EXTRACTOR'

I'll have to submit an internal change first.

@alexeagle

This comment has been minimized.

Copy link
Contributor

alexeagle commented Mar 11, 2019

mailed cl/237816725 to @mgechev to unblock this

@alan-agius4

This comment has been minimized.

Copy link
Contributor Author

alan-agius4 commented Mar 12, 2019

Caretaker: @alexeagle should be enough for this.

@ngbot ngbot bot added the PR action: merge label Mar 12, 2019

@kara kara closed this in df354d1 Mar 12, 2019

@alan-agius4 alan-agius4 deleted the alan-agius4:fix-bazel-api-extractor branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.