Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docs-infra): update AIO dependencies within their current ranges #29301

Closed
wants to merge 3 commits into
base: master
from

Conversation

@petebacondarwin
Copy link
Member

petebacondarwin commented Mar 14, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Some dependencies are outdated, or even vulnerable.

What is the new behavior?

All dependencies updated to latest (within their specified range in package.json)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Mar 14, 2019

@petebacondarwin

This comment has been minimized.

Copy link
Member Author

petebacondarwin commented Mar 14, 2019

So the application sizes have increased.

file expected master this PR
runtime 3713 3707 (-0.2%) 3676 (-1%) (-0.8% of master)
main 500343 502416 (+0.4%) 509261 (+1.8%) (+1.4% of master)
polyfills 53926 53927 (+0.0%) 57624 (+6.9%) (+6.9% of master)

Polyfills has gone up dramatically but I guess that is just an upstream issue.
Main seems to be a bit larger. I think this is acceptable @IgorMinar ?

@petebacondarwin

This comment has been minimized.

Copy link
Member Author

petebacondarwin commented Mar 14, 2019

Without updating zone.js to 0.8.29 the polyfills.js is only 54020, which is effectively +0% increase.

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Mar 14, 2019

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Mar 14, 2019

@matsko matsko closed this in 487d415 Mar 14, 2019

@petebacondarwin petebacondarwin deleted the petebacondarwin:upgrade-aio-deps branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.