Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add codefresh #29305

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@filipesilva
Copy link
Member

filipesilva commented Mar 14, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the new behavior?

Windows CI builds using codefresh will be available at https://g.codefresh.io/public/accounts/angular/pipelines/angular/angular/angular

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@googlebot googlebot added the cla: yes label Mar 14, 2019

@ngbot ngbot bot added this to the needsTriage milestone Mar 19, 2019

@filipesilva filipesilva marked this pull request as ready for review Mar 21, 2019

@filipesilva filipesilva requested review from IgorMinar and angular/fw-dev-infra as code owners Mar 21, 2019

@alexeagle
Copy link
Contributor

alexeagle left a comment

could you add a README like we did with BuildKite?

@filipesilva filipesilva force-pushed the codefresh branch from 4b7ed54 to d0d8ce0 Mar 21, 2019

@filipesilva

This comment has been minimized.

Copy link
Member Author

filipesilva commented Mar 21, 2019

@alexeagle added README.

@filipesilva

This comment has been minimized.

Copy link
Member Author

filipesilva commented Mar 21, 2019

caretaker: the test_aio and material-unit-tests failures are unrelated to this PR, and alexeagle should be all the approval needed for this change.

@ngbot

This comment has been minimized.

Copy link

ngbot bot commented Mar 21, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: test_aio" is failing
    pending status "ci/circleci: material-unit-tests" is pending
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.