Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): correctly remove placeholders inside of *ngFor with runtime i18n #29308

Closed
wants to merge 1 commit into
base: master
from

Conversation

@ocombe
Copy link
Contributor

ocombe commented Mar 14, 2019

Following my previous change for placeholders removal, some special code that was used to find the last created node was no longer needed and had wrong interactions with the *ngFor directive.
Removing it fixed the issue.

@ocombe ocombe requested review from kara and AndrewKushnir Mar 14, 2019

@ngbot ngbot bot added this to the needsTriage milestone Mar 14, 2019

@ocombe ocombe requested review from angular/fw-core as code owners Mar 14, 2019

@googlebot googlebot added the cla: yes label Mar 14, 2019

@kara
Copy link
Contributor

kara left a comment

Thanks for the quick turnaround, small nit

Show resolved Hide resolved packages/core/test/i18n_integration_spec.ts Outdated
fix(ivy): correctly remove placeholders inside of *ngFor with runtime…
… i18n

Following my previous change for placeholders removal, some special code that was used to find the last created node was no longer needed and had wrong interactions with the *ngFor directive.
Removing it fixed the issue.

@ocombe ocombe force-pushed the ocombe:fix/ivy/fw-1140-ng-for branch from 5833164 to 64ff79a Mar 14, 2019

@kara

kara approved these changes Mar 14, 2019

Copy link
Contributor

kara left a comment

LGTM

@kara

This comment has been minimized.

Copy link
Contributor

kara commented Mar 14, 2019

@AndrewKushnir
Copy link
Contributor

AndrewKushnir left a comment

👍

@kara

This comment has been minimized.

Copy link
Contributor

kara commented Mar 14, 2019

merge assistance: bot still thinks the "review" label is on this

@matsko matsko closed this in 7c297e0 Mar 14, 2019

@ocombe ocombe deleted the ocombe:fix/ivy/fw-1140-ng-for branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.