Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove configuration instructions at the top of the i18n guide #29313

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@brandonroberts
Copy link
Contributor

brandonroberts commented Mar 14, 2019

The instructions lead you to think you run this step before setting
up your locale. The command is mentioned further in the guide after
setup is complete.

Closes #26052

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

docs: remove configuration instructions at the top of the i18n guide
The instructions lead you to think you run this step before setting
up your locale. The command is mentioned further in the guide after
setup is complete.

Closes #26052
@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Mar 14, 2019

@matsko matsko closed this in f50928f Mar 14, 2019

matsko added a commit that referenced this pull request Mar 14, 2019

docs: remove configuration instructions at the top of the i18n guide (#…
…29313)

The instructions lead you to think you run this step before setting
up your locale. The command is mentioned further in the guide after
setup is complete.

Closes #26052

PR Close #29313

@brandonroberts brandonroberts deleted the brandonroberts:i18n-config-command branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.