Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): don't produce self-references in metadata #29317

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@alexeagle
Copy link
Contributor

commented Mar 14, 2019

Fixes #29315

@alexeagle alexeagle requested review from alxhub and alan-agius4 Mar 14, 2019

@alexeagle alexeagle requested a review from angular/tools-bazel as a code owner Mar 14, 2019

@googlebot googlebot added the cla: yes label Mar 14, 2019

@alxhub

alxhub approved these changes Mar 14, 2019

Copy link
Contributor

left a comment

👍

@matsko matsko closed this in 3facdeb Mar 15, 2019

@alan-agius4

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

Do we understand how none of the integration tests caught this issue?

@alexeagle

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2019

@alan-agius4 discussed that with @kyliau - we think the app in integration/bazel is too simple to exercise the codepath of resolving these symbols

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.