Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): Support new e2e project layout #29318

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@kyliau
Copy link
Member

commented Mar 14, 2019

angular/angular-cli#13780 changes the project
layout for the e2e application. It is no longer a separate project
and the e2e directory is now located alongside the existing project.

This commit updates Bazel scheamtics to support both old and new project
layout.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from angular/tools-bazel as a code owner Mar 14, 2019

@ngbot ngbot bot added this to the needsTriage milestone Mar 14, 2019

@googlebot googlebot added the cla: yes label Mar 14, 2019

fix(bazel): Support new e2e project layout
angular/angular-cli#13780 changes the project
layout for the e2e application. It is no longer a separate project
and the e2e directory is now located alongside the existing project.

This commit updates Bazel scheamtics to support both old and new project
layout.

@kyliau kyliau force-pushed the kyliau:e2e branch from 797d296 to beb5dce Mar 14, 2019

@kyliau kyliau requested a review from alexeagle Mar 14, 2019

@@ -5,7 +5,7 @@ ts_library(
name = "e2e_lib",
testonly = 1,
srcs = glob(["src/**/*.ts"]),
tsconfig = ":tsconfig.e2e.json",
tsconfig = ":tsconfig.e2e.json" if len(glob(["tsconfig.e2e.json"])) else ":tsconfig.json",

This comment has been minimized.

Copy link
@alexeagle

alexeagle Mar 14, 2019

Contributor

I don't think we care about the old one, but I guess it's okay to keep it

@matsko matsko closed this in 8ef690c Mar 15, 2019

@kyliau kyliau deleted the kyliau:e2e branch Mar 22, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

fix(bazel): Support new e2e project layout (angular#29318)
angular/angular-cli#13780 changes the project
layout for the e2e application. It is no longer a separate project
and the e2e directory is now located alongside the existing project.

This commit updates Bazel scheamtics to support both old and new project
layout.

PR Close angular#29318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.