Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): Remove @angular/upgrade from dev dependencies #29319

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@kyliau
Copy link
Member

kyliau commented Mar 14, 2019

@angular/upgrade is unnecessary, but it's required by router/upgrade.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

fix(bazel): Remove @angular/upgrade from dev dependencies
@angular/upgrade is unnecessary, but it's required by router/upgrade.

@kyliau kyliau requested a review from angular/tools-bazel as a code owner Mar 14, 2019

@ngbot ngbot bot added this to the needsTriage milestone Mar 14, 2019

@googlebot googlebot added the cla: yes label Mar 14, 2019

@kyliau kyliau requested a review from alexeagle Mar 14, 2019

@@ -16,6 +16,7 @@
"exclude": [
"node_modules/@angular/bazel/**",
"node_modules/@angular/compiler-cli/**",
"node_modules/@angular/**/testing/**"
"node_modules/@angular/**/testing/**",
"node_modules/@angular/router/upgrade*"

This comment has been minimized.

@gkalpak

gkalpak Mar 15, 2019

Member

OOC, why this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.