Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): fix misleading tslint schematic message #29320

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@devversion
Copy link
Member

devversion commented Mar 14, 2019

Fixes the incorrect failure message or the TSLint rule that
is used within Google. The TSLint rule is not part of the
public schematic code.

Additionally in order to make it easier to understand what
action the developer needs to take, we rather print out the
expected "static: true/false" statement instead of saying that
a query needs to be static or dynamic. Dynamic is ambiguous, as
there is no dynamic: true option.

@devversion devversion requested a review from angular/fw-core as a code owner Mar 14, 2019

@googlebot googlebot added the cla: yes label Mar 14, 2019

refactor(core): fix misleading tslint schematic message
Fixes the incorrect failure message or the TSLint rule that
is used within Google. The TSLint rule is not part of the
public schematic code.

Additionally in order to make it easier to understand what
action the developer needs to take, we rather print out the
expected "static: true/false" statement instead of saying that
a query needs to be static or dynamic. Dynamic is ambiguous, as
there is no `dynamic: true` option.

@devversion devversion force-pushed the devversion:refactor/core-fix-misleading-tslint-msg branch from 581ee2a to e16b76b Mar 14, 2019

@ngbot ngbot bot modified the milestone: needsTriage Mar 14, 2019

@kara

kara approved these changes Mar 18, 2019

Copy link
Contributor

kara left a comment

LGTM

@kara

This comment has been minimized.

Copy link
Contributor

kara commented Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.