Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update router.ts #29322

Open
wants to merge 1 commit into
base: 7.2.x
from

Conversation

Projects
None yet
3 participants
@debangob
Copy link

debangob commented Mar 15, 2019

Provides navigation error details.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • [x ] Other... Please describe:
    I need this change so that in case navigation error occurs and unhanded warning is outputted, error details is also written into console. This way developer can find more details on the actual error.

What is the current behavior?

Currently when navigation error occurs only 'Unhandled Navigation Error:' is outputted without the error details.

Issue Number: N/A

What is the new behavior?

With the change both error message text and the actual error will be outputted in the console.

Does this PR introduce a breaking change?

  • Yes
  • [ x] No

Other information

Update router.ts
Provides navigation error details.
@googlebot

This comment has been minimized.

Copy link

googlebot commented Mar 15, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Mar 15, 2019

@debangob

This comment has been minimized.

Copy link
Author

debangob commented Mar 15, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
I signed it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@debangob debangob marked this pull request as ready for review Mar 15, 2019

@debangob debangob requested a review from angular/fw-router as a code owner Mar 15, 2019

@ngbot ngbot bot added this to the needsTriage milestone Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.