Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): add temporary hack for deprecatedOverrideProvider #29324

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@kara
Copy link
Contributor

kara commented Mar 15, 2019

HACK: This is NOT the correct implementation for deprecatedOverrideProvider.
We do not plan to implement this at all since the API is deprecated and
scheduled for removal in V8. This hack is here temporarily for Ivy testing
until we transition apps inside Google to the overrideProvider API. At that
point, we will be able to remove this method entirely. In the meantime, we
can use overrideProvider here to test apps with Ivy that don't care about
eager instantiation. This fixes 97% of cases in our blueprint.

@googlebot googlebot added the cla: yes label Mar 15, 2019

@kara kara force-pushed the kara:deprecatedOverrideProvider branch from c9126ce to b59a3d3 Mar 15, 2019

@kara kara marked this pull request as ready for review Mar 15, 2019

@kara kara requested a review from angular/fw-core as a code owner Mar 15, 2019

@ngbot ngbot bot added this to the needsTriage milestone Mar 15, 2019

fix(ivy): add temporary hack for deprecatedOverrideProvider
HACK: This is NOT the correct implementation for deprecatedOverrideProvider.
We do not plan to implement this at all since the API is deprecated and
scheduled for removal in V8. This hack is here temporarily for Ivy testing
until we transition apps inside Google to the overrideProvider API. At that
point, we will be able to remove this method entirely. In the meantime, we
can use overrideProvider here to test apps with Ivy that don't care about
eager instantiation. This fixes 97% of cases in our blueprint.

@kara kara force-pushed the kara:deprecatedOverrideProvider branch from b59a3d3 to 512d9a5 Mar 15, 2019

@kara

This comment has been minimized.

Copy link
Contributor Author

kara commented Mar 15, 2019

@alxhub

alxhub approved these changes Mar 15, 2019

@matsko matsko closed this in 7561698 Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.