Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): parse incorrect ML open tag as text #29328

Conversation

Projects
None yet
6 participants
@pkozlowski-opensource
Copy link
Member

commented Mar 15, 2019

This PR aligns markup language lexer with the previous behaviour in version 7.x:
https://stackblitz.com/edit/angular-iancj2

While this behaviour is not perfect (we should be giving users an error message
here about invalid HTML instead of assuming text node) this is probably best we
can do without more substantial re-write of lexing / parsing infrastructure.

This PR just fixes #29231 and restores VE behaviour - a more elaborate fix will
be done in a separate PR as it requires non-trivial rewrites.

fix(core): parse incorrect ML open tag as text
This PR alligns markup language lexer with the previous behaviour in version 7.x:
https://stackblitz.com/edit/angular-iancj2

While this behaviour is not perfect (we should be giving users an error message
here about invalid HTML instead of assuming text node) this is probably best we
can do without more substential re-write of lexing / parsing infrastructure.

This PR just fixes #29231 and restores VE behaviour - a more elaborate fix will
be done in a separate PR as it requries non-trivial rewrites.
@kara

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

@matsko matsko closed this in 4605df8 Mar 19, 2019

@matsko matsko reopened this Mar 19, 2019

@matsko

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

@pkozlowski-opensource I'm reverting + reopening this so that it doesn't land into the release later today. I will re-merge this PR tomorrow morning.

matsko added a commit that referenced this pull request Mar 19, 2019

@kara

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

@matsko FYI, this commit is fine to go in the release. It just doesn't have to go out in the release.

@matsko matsko closed this in dafbbf8 Mar 20, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

fix(core): parse incorrect ML open tag as text (angular#29328)
This PR alligns markup language lexer with the previous behaviour in version 7.x:
https://stackblitz.com/edit/angular-iancj2

While this behaviour is not perfect (we should be giving users an error message
here about invalid HTML instead of assuming text node) this is probably best we
can do without more substential re-write of lexing / parsing infrastructure.

This PR just fixes angular#29231 and restores VE behaviour - a more elaborate fix will
be done in a separate PR as it requries non-trivial rewrites.

PR Close angular#29328

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

fix(core): parse incorrect ML open tag as text (angular#29328)
This PR alligns markup language lexer with the previous behaviour in version 7.x:
https://stackblitz.com/edit/angular-iancj2

While this behaviour is not perfect (we should be giving users an error message
here about invalid HTML instead of assuming text node) this is probably best we
can do without more substential re-write of lexing / parsing infrastructure.

This PR just fixes angular#29231 and restores VE behaviour - a more elaborate fix will
be done in a separate PR as it requries non-trivial rewrites.

PR Close angular#29328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.