Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): correct regexp test for self-references in metadata #29346

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@alexeagle
Copy link
Contributor

commented Mar 15, 2019

Add a test that catches the mistake, should have had this in the previous change

fix(bazel): correct regexp test for self-references in metadata
Add a test that catches the mistake, should have had this in the previous change

@alexeagle alexeagle requested a review from mgechev Mar 15, 2019

@alexeagle alexeagle requested a review from angular/tools-bazel as a code owner Mar 15, 2019

@googlebot googlebot added the cla: yes label Mar 15, 2019

@@ -415,7 +415,7 @@ export * from '${srcDirRelative(inputPath, typingsFile.replace(/\.d\.tsx?$/, '')
if (metadata.exports) {
// Strip re-exports which are now self-references
metadata.exports =
metadata.exports.filter((e: {from: string}) => !relativePathRegex.test(e.from));
metadata.exports.filter((e: {from: string}) => !e.from.match(relativePathRegex));

This comment has been minimized.

Copy link
@gkalpak

gkalpak Mar 16, 2019

Member

Might be worth adding a comment here, because .test() seems like the right thing to do and is easy to miss the implications of the g flag.

@jasonaden jasonaden closed this in 9d090cb Mar 18, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

fix(bazel): correct regexp test for self-references in metadata (angu…
…lar#29346)

Add a test that catches the mistake, should have had this in the previous change

PR Close angular#29346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.