Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bazel): Upgrade rules_sass #29388

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@kyliau
Copy link
Member

commented Mar 18, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from angular/fw-integration as a code owner Mar 18, 2019

@ngbot ngbot bot added this to the needsTriage milestone Mar 18, 2019

@googlebot googlebot added the cla: yes label Mar 18, 2019

@kyliau kyliau force-pushed the kyliau:sass branch from c252d16 to 96da1cd Mar 19, 2019

@kyliau kyliau requested a review from angular/tools-bazel as a code owner Mar 19, 2019

@kyliau kyliau force-pushed the kyliau:sass branch 3 times, most recently from 697637f to 9d24839 Mar 19, 2019

@kyliau

This comment has been minimized.

Copy link
Member Author

commented Mar 19, 2019

caretaker: tests are done and are all green but CircleCI status was not updated.

@alexeagle

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

Greg landed a change today, looks like this needs a rebase?
Also framework just released beta.9 which we should pick up, has the ngfactory UMD change

@kyliau kyliau force-pushed the kyliau:sass branch from 9d24839 to 72e6df7 Mar 20, 2019

@kyliau kyliau force-pushed the kyliau:sass branch from 72e6df7 to 412be34 Mar 20, 2019

@kyliau kyliau changed the title feat(bazel): Upgrade rules_nodejs and rules_sass feat(bazel): Upgrade rules_sass Mar 20, 2019

@matsko matsko closed this in d6d081e Mar 20, 2019

@kyliau kyliau deleted the kyliau:sass branch Mar 22, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.