Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(bazel): update to nodejs rules 0.27.8 #29508

Closed
Closed
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -15,8 +15,8 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
# Fetch rules_nodejs so we can install our npm dependencies
http_archive(
name = "build_bazel_rules_nodejs",
sha256 = "fb87ed5965cef93188af9a7287511639403f4b0da418961ce6defb9dcf658f51",
urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.27.7/rules_nodejs-0.27.7.tar.gz"],
sha256 = "88e5e579fb9edfbd19791b8a3c6bfbe16ae3444dba4b428e5efd36856db7cf16",
urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.27.8/rules_nodejs-0.27.8.tar.gz"],
)

# Check the bazel version and download npm dependencies
@@ -5,8 +5,8 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
# Fetch rules_nodejs so we can install our npm dependencies
http_archive(
name = "build_bazel_rules_nodejs",
sha256 = "fb87ed5965cef93188af9a7287511639403f4b0da418961ce6defb9dcf658f51",
urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.27.7/rules_nodejs-0.27.7.tar.gz"],
sha256 = "88e5e579fb9edfbd19791b8a3c6bfbe16ae3444dba4b428e5efd36856db7cf16",
urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.27.8/rules_nodejs-0.27.8.tar.gz"],
)

# Fetch sass rules for compiling sass files
@@ -9,9 +9,12 @@
],
"experimentalDecorators": true,
"types": [],
"module": "umd",
"module": "amd",
"moduleResolution": "node"
},
"angularCompilerOptions": {
"enableSummariesForJit": true
},
"include": [
"node_modules/@angular/**/*"
],
@@ -19,7 +19,8 @@
"@angular/bazel": "packages-dist:bazel",
"@angular/compiler": "packages-dist:compiler",
"@angular/compiler-cli": "packages-dist:compiler-cli",
"@bazel/karma": "0.27.7",
"@bazel/karma": "0.27.8",
"@bazel/typescript": "0.27.8",
"@types/jasmine": "2.8.8",
"@types/source-map": "0.5.1",
"protractor": "5.1.2",
@@ -123,10 +123,10 @@
dependencies:
tslib "^1.9.0"

"@bazel/karma@0.27.7":
version "0.27.7"
resolved "https://registry.yarnpkg.com/@bazel/karma/-/karma-0.27.7.tgz#abe1cf48be97fbad84ad38e9d32b823e367b8d81"
integrity sha512-SlYtePQWoa1+xKMEZdp27n4WZsocfUaUR10p3jaZZ0uhOcoAvuOVTaG+sidUJCoVuF8s6IPjbSOGN4FWVgXUjg==
"@bazel/karma@0.27.8":
version "0.27.8"
resolved "https://registry.yarnpkg.com/@bazel/karma/-/karma-0.27.8.tgz#e9c4ef4190b2da3c23b01bc7b79830c3985cfb1f"
integrity sha512-H6TDIUcP+nW4dvjQeCINAyGLMnEV45maAM0HxModAe0cKfVxBpZrVKwG6ZuKChvQWY2nLDtN3C9K/GGISxP7hg==
dependencies:
jasmine-core "2.8.0"
karma "^4.0.0"
@@ -140,10 +140,10 @@
semver "5.6.0"
tmp "0.0.33"

"@bazel/typescript@^0.27.7":
version "0.27.7"
resolved "https://registry.yarnpkg.com/@bazel/typescript/-/typescript-0.27.7.tgz#ff2d6469357ff68faccc75976d435fec0175e988"
integrity sha512-Eeu42RM6Ss/se3Bdv+OBfY159N9uOlUZp4XHgZixq1PHwuohRDPIEdEnci/pe3TDsiY25YOi7hjemM90gu5ppg==
"@bazel/typescript@0.27.8":
version "0.27.8"
resolved "https://registry.yarnpkg.com/@bazel/typescript/-/typescript-0.27.8.tgz#b9a566e4a95c0425b52961e9e899b59c7b22efcf"
integrity sha512-beApzTtgm+lKrhQf5OgPk1amGfi5PJ1DCVVWYbNsbJP/Joi+NgCrgykG55NbaJIzEc+6IQoh8y0QUVMYRt562Q==
dependencies:
protobufjs "5.0.3"
semver "5.6.0"
@@ -45,8 +45,5 @@ protractor_web_test_suite(
],
on_prepare = ":ts_on_prepare",
server = "//src:prodserver",
# TODO(kyliau): Re-enable once we figure out why rollup complains about
# "Dynamic requires are not currently supported by rollup-plugin-commonjs"
tags = ["manual"],
deps = [":e2e"],
)
@@ -37,8 +37,8 @@
"@angular-devkit/schematics": "^7.3.2",
"@angular/bazel": "file:./tools/npm/@angular_bazel",
"@bazel/jasmine": "0.26.0",
"@bazel/karma": "0.27.7",
"@bazel/typescript": "0.27.7",
"@bazel/karma": "0.27.8",
"@bazel/typescript": "0.27.8",
This conversation was marked as resolved by kyliau

This comment has been minimized.

Copy link
@kyliau

kyliau Mar 25, 2019

Member

did this get pulled in from the transitive deps of @angular/bazel before?

This comment has been minimized.

Copy link
@gregmagolan

gregmagolan Mar 25, 2019

Author Contributor

Yup. It’s a peer dep now

"@microsoft/api-extractor": "^7.0.21",
"@schematics/angular": "^7.3.5",
"@types/angular": "^1.6.47",
@@ -86,6 +86,7 @@
"protractor": "^5.4.2",
"reflect-metadata": "^0.1.3",
"rollup": "^1.1.0",
"rollup-plugin-amd": "^3.0.0",
"rollup-plugin-commonjs": "^9.2.1",
"rollup-plugin-node-resolve": "^4.0.0",
"rollup-plugin-sourcemaps": "^0.4.2",
@@ -22,7 +22,6 @@
"@angular-devkit/architect": "^0.13.4",
"@angular-devkit/core": "^7.0.4",
"@angular-devkit/schematics": "^7.3.0-rc.0",
"@bazel/typescript": "^0.27.7",
"@microsoft/api-extractor": "^7.0.21",
"@schematics/angular": "^7.3.5",
"@types/node": "6.0.84",
@@ -32,6 +31,7 @@
},
"peerDependencies": {
"@angular/compiler-cli": "0.0.0-PLACEHOLDER",
"@bazel/typescript": "^0.27.8",
"typescript": ">=3.3.3333 <3.4"
},
"repository": {
@@ -16,6 +16,7 @@ nodejs_binary(
"@npm//@angular-devkit/build-optimizer",
"@npm//is-builtin-module",
"@npm//rollup",
"@npm//rollup-plugin-amd",
"@npm//rollup-plugin-commonjs",
"@npm//rollup-plugin-node-resolve",
"@npm//rollup-plugin-sourcemaps",
@@ -12,8 +12,8 @@ workspace(name = "project")

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

RULES_NODEJS_VERSION = "0.27.7"
RULES_NODEJS_SHA256 = "fb87ed5965cef93188af9a7287511639403f4b0da418961ce6defb9dcf658f51"
RULES_NODEJS_VERSION = "0.27.8"
RULES_NODEJS_SHA256 = "88e5e579fb9edfbd19791b8a3c6bfbe16ae3444dba4b428e5efd36856db7cf16"
http_archive(
name = "build_bazel_rules_nodejs",
sha256 = RULES_NODEJS_SHA256,
@@ -49,7 +49,8 @@ function addDevDependenciesToPackageJson(options: Schema) {
'@angular/bazel': angularCoreVersion,
'@bazel/bazel': '^0.23.0',
'@bazel/ibazel': '^0.9.0',
'@bazel/karma': '^0.27.7',
'@bazel/karma': '^0.27.8',
'@bazel/typescript': '^0.27.8',
};

const recorder = host.beginUpdate(packageJson);
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.