Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-cli): ensure LogicalProjectPaths always start with a slash #29627

Closed

Conversation

@petebacondarwin
Copy link
Member

commented Apr 1, 2019

Previously, if a matching rootDir ended with a slash then the path
returned from logicalPathOfFile() would not start with a slash,
which is inconsistent.

@petebacondarwin petebacondarwin requested a review from alxhub Apr 1, 2019

@petebacondarwin petebacondarwin requested a review from angular/fw-compiler as a code owner Apr 1, 2019

@ngbot ngbot bot added this to the needsTriage milestone Apr 1, 2019

@googlebot googlebot added the cla: yes label Apr 1, 2019

@gkalpak

gkalpak approved these changes Apr 1, 2019

@jasonaden

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

@petebacondarwin petebacondarwin requested a review from alxhub Apr 3, 2019

@alxhub

alxhub approved these changes Apr 4, 2019

@petebacondarwin petebacondarwin force-pushed the petebacondarwin:ngtsc-logical-path-fix branch 2 times, most recently from 68532cc to b7f48a7 Apr 4, 2019

fix(compiler-cli): ensure LogicalProjectPaths always start with a slash
Previously, if a matching rootDir ended with a slash then the path
returned from `logicalPathOfFile()` would not start with a slash,
which is inconsistent.

@petebacondarwin petebacondarwin force-pushed the petebacondarwin:ngtsc-logical-path-fix branch from b7f48a7 to 93df013 Apr 8, 2019

@IgorMinar IgorMinar closed this in e02684e Apr 8, 2019

@petebacondarwin petebacondarwin deleted the petebacondarwin:ngtsc-logical-path-fix branch Apr 8, 2019

DeveloperFromUkraine added a commit to DeveloperFromUkraine/angular that referenced this pull request Apr 11, 2019

fix(compiler-cli): ensure LogicalProjectPaths always start with a sla…
…sh (angular#29627)

Previously, if a matching rootDir ended with a slash then the path
returned from `logicalPathOfFile()` would not start with a slash,
which is inconsistent.

PR Close angular#29627

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

fix(compiler-cli): ensure LogicalProjectPaths always start with a sla…
…sh (angular#29627)

Previously, if a matching rootDir ended with a slash then the path
returned from `logicalPathOfFile()` would not start with a slash,
which is inconsistent.

PR Close angular#29627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.