Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-cli): ngcc - cope with processing entry-points multiple … #29657

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@petebacondarwin
Copy link
Member

commented Apr 2, 2019

…times

With the new API, where you can choose to only process the first
matching format, it is possible to process an entry-point multiple
times, if you pass in a different format each time.

Previously, ngcc would always try to process the typings files for
the entry-point along with processing the first format of the current
execution of ngcc. But this meant that it would be trying to process
the typings a second time.

Now we only process the typings if they have not already been
processed as part of processing another format in another
even if it was in a different execution of ngcc.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

fix(compiler-cli): ngcc - cope with processing entry-points multiple …
…times

With the new API, where you can choose to only process the first
matching format, it is possible to process an entry-point multiple
times, if you pass in a different format each time.

Previously, ngcc would always try to process the typings files for
the entry-point along with processing the first format of the current
execution of ngcc. But this meant that it would be trying to process
the typings a second time.

Now we only process the typings if they have not already been
processed as part of processing another format in another
even if it was in a different execution of ngcc.

@petebacondarwin petebacondarwin force-pushed the petebacondarwin:FW-1211 branch from fdc518e to 3755129 Apr 2, 2019

@gkalpak

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

BTW, this shouldn't need approval from fw-compiler but fw-ngcc. (Fix: #29660)

@gkalpak

gkalpak approved these changes Apr 2, 2019

@jasonaden jasonaden closed this in 6b39c9c Apr 2, 2019

@petebacondarwin petebacondarwin deleted the petebacondarwin:FW-1211 branch Apr 3, 2019

DeveloperFromUkraine added a commit to DeveloperFromUkraine/angular that referenced this pull request Apr 11, 2019

fix(compiler-cli): ngcc - cope with processing entry-points multiple …
…times (angular#29657)

With the new API, where you can choose to only process the first
matching format, it is possible to process an entry-point multiple
times, if you pass in a different format each time.

Previously, ngcc would always try to process the typings files for
the entry-point along with processing the first format of the current
execution of ngcc. But this meant that it would be trying to process
the typings a second time.

Now we only process the typings if they have not already been
processed as part of processing another format in another
even if it was in a different execution of ngcc.

PR Close angular#29657

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

fix(compiler-cli): ngcc - cope with processing entry-points multiple …
…times (angular#29657)

With the new API, where you can choose to only process the first
matching format, it is possible to process an entry-point multiple
times, if you pass in a different format each time.

Previously, ngcc would always try to process the typings files for
the entry-point along with processing the first format of the current
execution of ngcc. But this meant that it would be trying to process
the typings a second time.

Now we only process the typings if they have not already been
processed as part of processing another format in another
even if it was in a different execution of ngcc.

PR Close angular#29657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.