Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): support running ng-add on minimal applications #29681

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@alan-agius4
Copy link
Contributor

commented Apr 3, 2019

Minimal applications don't have test and e2e targets but we are not currently checking if they exists.

Fixes #29680

@alan-agius4 alan-agius4 requested a review from angular/tools-bazel as a code owner Apr 3, 2019

@googlebot googlebot added the cla: yes label Apr 3, 2019

@alan-agius4 alan-agius4 force-pushed the alan-agius4:ng-add-bazel branch from 17705bc to 000b523 Apr 3, 2019

fix(bazel): support running ng-add on minimal applications
Minimal applications don't have `test` and `e2e` targets but we are not currently checking if they exists.

Fixes #29680

@alan-agius4 alan-agius4 force-pushed the alan-agius4:ng-add-bazel branch from 000b523 to 6046f28 Apr 3, 2019

@ngbot ngbot bot added this to the needsTriage milestone Apr 3, 2019

@kyliau

kyliau approved these changes Apr 3, 2019

@jasonaden jasonaden closed this in 9810c6c Apr 3, 2019

@alan-agius4 alan-agius4 deleted the alan-agius4:ng-add-bazel branch Apr 4, 2019

DeveloperFromUkraine added a commit to DeveloperFromUkraine/angular that referenced this pull request Apr 11, 2019

fix(bazel): support running ng-add on minimal applications (angular#2…
…9681)

Minimal applications don't have `test` and `e2e` targets but we are not currently checking if they exists.

Fixes angular#29680

PR Close angular#29681

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

fix(bazel): support running ng-add on minimal applications (angular#2…
…9681)

Minimal applications don't have `test` and `e2e` targets but we are not currently checking if they exists.

Fixes angular#29680

PR Close angular#29681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.