Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to nodejs rules 0.27.10 #29694

Closed

Conversation

Projects
None yet
4 participants
@gregmagolan
Copy link
Contributor

commented Apr 4, 2019

Also,

  • adds configuration_env_vars = ["compile"] to generated @npm//@angular/bazel/bin:ngc-wrapped nodejs_binary using new bazelBin additionalAttributes yarn_install & npm_install feature. This is required to be able to compile with Ivy using ng_module by setting build --define=compile=aot in .bazelrc.

  • /integration/bazel: removes umd, ngfactory & ngsummary scripts that no longer need to be explicitly specified in ts_devserver & ts_web_test_suite in

gregmagolan added some commits Apr 3, 2019

fix(bazel): add configuration_env_vars = ["compile"] to generated @np…
…m//@angular/bazel/bin:ngc-wrapped nodejs_binary

@gregmagolan gregmagolan requested a review from alexeagle Apr 4, 2019

@gregmagolan gregmagolan requested review from angular/fw-dev-infra as code owners Apr 4, 2019

@googlebot googlebot added the cla: yes label Apr 4, 2019

@ngbot ngbot bot added this to the needsTriage milestone Apr 4, 2019

@gregmagolan

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

Generated ngc-wrapped binary target in /integration/bazel now looks like this:

# Wire up the `bin` entry `ngc-wrapped`
nodejs_binary(
    name = "ngc-wrapped__bin",
    entry_point = "@angular/bazel/src/ngc-wrapped/index.js",
    install_source_map_support = False,
    data = [":bazel__pkg"],
    configuration_env_vars = ["compile"],
)

with the added configuration_env_vars attribute.

@kyliau kyliau referenced this pull request Apr 4, 2019

Closed

build(bazel): update to rules_nodejs 0.27.10 #29693

2 of 14 tasks complete

@gregmagolan gregmagolan requested a review from kyliau Apr 4, 2019

@gregmagolan

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

@alexeagle

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

CI failure looks legit:

HeadlessChrome 69.0.3497 (Linux 0.0.0) ERROR: 'There is no timestamp for tslib.js!'

04 04 2019 02:17:04.392:WARN [web-server]: 404: /tslib.js
HeadlessChrome 69.0.3497 (Linux 0.0.0) ERROR
  {
    "message": "Uncaught Error: Script error for \"tslib\", needed by: project/src/app/app.component, project/src/app/widget/widget.component

My guess is that something has importHelpers: true in tsconfig, which is fine, and then deps on tslib, but we are missing the third-party-lib getting included in devSources still.

@gregmagolan gregmagolan force-pushed the gregmagolan:build/nodejs-rules-0.27.10 branch 2 times, most recently from 12a5062 to bdd7037 Apr 4, 2019

@gregmagolan gregmagolan force-pushed the gregmagolan:build/nodejs-rules-0.27.10 branch from bdd7037 to 3c57d1f Apr 4, 2019

@gregmagolan

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

My guess is that something has importHelpers: true in tsconfig, which is fine, and then deps on tslib, but we are missing the third-party-lib getting included in devSources still.

Seems like. I added tslib back to ts_devserver & ts_web_test_suite here. We can fix this is another PR.

@kyliau

kyliau approved these changes Apr 4, 2019

@IgorMinar IgorMinar closed this in 7fbe138 Apr 4, 2019

IgorMinar added a commit that referenced this pull request Apr 4, 2019

fix(bazel): add configuration_env_vars = ["compile"] to generated @np…
…m//@angular/bazel/bin:ngc-wrapped nodejs_binary (#29694)

PR Close #29694

IgorMinar added a commit that referenced this pull request Apr 4, 2019

IgorMinar added a commit that referenced this pull request Apr 4, 2019

IgorMinar added a commit that referenced this pull request Apr 4, 2019

DeveloperFromUkraine added a commit to DeveloperFromUkraine/angular that referenced this pull request Apr 11, 2019

DeveloperFromUkraine added a commit to DeveloperFromUkraine/angular that referenced this pull request Apr 11, 2019

DeveloperFromUkraine added a commit to DeveloperFromUkraine/angular that referenced this pull request Apr 11, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.