Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): remove karma-jasmine from ts_web_test_suite #29695

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@kyliau
Copy link
Member

commented Apr 4, 2019

karma-jasmine dep is unnecessary and has no effect.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from angular/tools-bazel as a code owner Apr 4, 2019

@googlebot googlebot added the cla: yes label Apr 4, 2019

@ngbot ngbot bot added this to the needsTriage milestone Apr 4, 2019

@googlebot googlebot added the cla: yes label Apr 4, 2019

@kyliau kyliau changed the title remove karma-jasmine from ts_web_test_suite fix(bazel): remove karma-jasmine from ts_web_test_suite Apr 4, 2019

@kyliau kyliau requested a review from gregmagolan Apr 4, 2019

@IgorMinar IgorMinar closed this in 2bd9214 Apr 4, 2019

@kyliau kyliau deleted the kyliau:karma branch Apr 4, 2019

DeveloperFromUkraine added a commit to DeveloperFromUkraine/angular that referenced this pull request Apr 11, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.