Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bazel builder #29720

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@alan-agius4
Copy link
Contributor

commented Apr 5, 2019

build: update angular cli packages to latest beta

feat(bazel): update the build to use the new architect api
With this change the builder has been updated to use the latest architect API and make it compatible with the latest CLI

Fixes angular/angular-cli#14082

refactor: use standard node resolution methods where possible
This aligns with the CLI as we'd like to use standard node resolutions when possible angular/angular-cli#14029

This also makes the builder run on windows

@googlebot googlebot added the cla: yes label Apr 5, 2019

@alan-agius4 alan-agius4 force-pushed the alan-agius4:bazel-builder branch from 8767077 to 328bf44 Apr 5, 2019

@ngbot ngbot bot added this to the needsTriage milestone Apr 5, 2019

@alan-agius4 alan-agius4 force-pushed the alan-agius4:bazel-builder branch 8 times, most recently from 3b9b614 to 4da6151 Apr 5, 2019

@alan-agius4 alan-agius4 force-pushed the alan-agius4:bazel-builder branch from 4da6151 to 11d239e Apr 5, 2019

@alan-agius4

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

@kyliau there seems to be a problem, because @bazel/karma still uses karma-jasmine 1 while in the workspace we uses version 2.

The same thing applies for jasmine-core

test is throwing an error No provider for "framework:jasmine"!

@alan-agius4 alan-agius4 force-pushed the alan-agius4:bazel-builder branch from 11d239e to b8f03b9 Apr 5, 2019

@alan-agius4 alan-agius4 marked this pull request as ready for review Apr 5, 2019

@alan-agius4 alan-agius4 requested review from angular/fw-dev-infra as code owners Apr 5, 2019

Show resolved Hide resolved integration/bazel-schematics/package.json Outdated
Show resolved Hide resolved package.json
Show resolved Hide resolved packages/bazel/src/builders/bazel.ts

@alan-agius4 alan-agius4 force-pushed the alan-agius4:bazel-builder branch 2 times, most recently from a4e8b28 to 0f7ad56 Apr 5, 2019

@kyliau

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

@alan-agius4 CI is green

feat(bazel): update the build to use the new architect api
With this change the builder has been updated to use the latest architect API and make it compatable with the latest CLI

Fixes angular/angular-cli#14082

@kyliau kyliau force-pushed the alan-agius4:bazel-builder branch from 2dcfacd to 1bc2b7e Apr 6, 2019

@alan-agius4

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

Thanks @kyliau for your help

@IgorMinar IgorMinar closed this in e381155 Apr 8, 2019

IgorMinar added a commit that referenced this pull request Apr 8, 2019

feat(bazel): update the build to use the new architect api (#29720)
With this change the builder has been updated to use the latest architect API and make it compatable with the latest CLI

Fixes angular/angular-cli#14082

PR Close #29720

@alan-agius4 alan-agius4 deleted the alan-agius4:bazel-builder branch Apr 8, 2019

DeveloperFromUkraine added a commit to DeveloperFromUkraine/angular that referenced this pull request Apr 11, 2019

DeveloperFromUkraine added a commit to DeveloperFromUkraine/angular that referenced this pull request Apr 11, 2019

feat(bazel): update the build to use the new architect api (angular#2…
…9720)

With this change the builder has been updated to use the latest architect API and make it compatable with the latest CLI

Fixes angular/angular-cli#14082

PR Close angular#29720

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

feat(bazel): update the build to use the new architect api (angular#2…
…9720)

With this change the builder has been updated to use the latest architect API and make it compatable with the latest CLI

Fixes angular/angular-cli#14082

PR Close angular#29720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.