Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): resolve ts compile issues due to lenient tsconfig #29843

Closed

Conversation

Projects
None yet
4 participants
@IgorMinar
Copy link
Member

commented Apr 11, 2019

The code failed presubmit in google3 because the original ts config was not as strict
as the one used elsewhere in angular/angular and google3.

fix(core): resolve ts compile issues due to lenient tsconfig
The code failed presubmit in google3 because the original ts config was not as strict
as the one used elsewhere in angular/angular and google3.
@mary-poppins

This comment has been minimized.

Copy link

commented Apr 11, 2019

@IgorMinar IgorMinar closed this in 54058ba Apr 11, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

fix(core): resolve ts compile issues due to lenient tsconfig (angular…
…#29843)

The code failed presubmit in google3 because the original ts config was not as strict
as the one used elsewhere in angular/angular and google3.

PR Close angular#29843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.