Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(compiler-cli): pass config path to ts.parseJsonConfigFileContent #29872
Please check if your PR fulfills the following requirements:
What kind of change does this PR introduce?
What is the current behavior?
The config path is an optional argument to
The new TS 3.4 incremental build functionality relies on this property being present: https://github.com/Microsoft/TypeScript/blob/025d82633915b67003ea38ba40b9239a19721c13/src/compiler/emitter.ts#L56-L57
When using The compiler-cli
Related to angular/angular-cli#13941.
What is the new behavior?
This PR fixes this omission and should allow JIT users of @ngtools/webpack to set the
I tested this in JIT and saw a small decrease in build times in a small project. In AOT the incremental option didn't seem to be used at all, due to how
Does this PR introduce a breaking change?
If you want your PR to be merged, it has to pass all the CI checks.
If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.