Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(upgrade): allowing attribute usage #29892
Please check if your PR fulfills the following requirements:
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #16695
What is the new behavior?
Allowing both attribute and element for downgraded components.
Does this PR introduce a breaking change?
I'm afraid we can't accept this PR as is. A change like this needs to be thought out, tested and documented.
One option to address the above concerns would be to make it explicit when a downgraded component is supposed to match on attributes instead of (or in addition to) tag names. For example,
This would avoid the breaking change (since all existing code would continue to work as it did before and users would have to opt-in to matching attributes) and it would make it explicit/obvious that a particular downgraded component in supposed to match attributes.
BTW, whatever direction we decide to go, we'll need documentation and tests
Thank you very much for your feedback! Definitely agree with you on that this PR as is would change existing behaviour.
I like the options you mentioned and personally would lean towards the latest as it is giving most flexibility (additional paremeter to amend the the
I am a little concerned of opening up
But I like being able to specify either