Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform-browser): add unique input event plugin #29895

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@DerSizeS
Copy link

DerSizeS commented Apr 14, 2019

This plugin checks if value of element is changed before firing input event



Internet Explorer 10+ implements 'input' event but it erroneously fires under various situations, e.g. when placeholder changes, when non english placeholder is used or a control is focused

Fixed only from Edge 15.15002
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/101220/
This bug will not be fixed in Internet Explorer
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/11405058/

Closes #14440, #17951, #15299, #16151

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Internet Explorer 10+ implements 'input' event but it erroneously fires under various situations, e.g. when placeholder changes, when non english placeholder is used or a control is focused

Issue Number: #14440, #17951, #15299, #16151

What is the new behavior?

If plugin config is provided – input event is fired when value of element is changed.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@DerSizeS DerSizeS requested a review from angular/fw-core as a code owner Apr 14, 2019

@googlebot googlebot added the cla: yes label Apr 14, 2019

@DerSizeS DerSizeS force-pushed the DerSizeS:fix-ie-input-event branch 7 times, most recently from d1cfbf2 to 6a5a982 Apr 14, 2019

@DerSizeS DerSizeS requested a review from angular/fw-public-api as a code owner Apr 15, 2019

@mhevery mhevery self-assigned this Apr 17, 2019

@ngbot ngbot bot added this to the needsTriage milestone Apr 17, 2019

fix(platform-browser): add unique input event plugin
This plugin checks if value of element is changed before firing input event



Internet Explorer 10+ implements 'input' event but it erroneously fires under various situations, e.g. when placeholder changes, when non english placeholder is used or a control is focused
Fixed only from Edge 15.15002 https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/101220/
This bug will not be fixed in Internet Explorer https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/11405058/

Closes #14440, #17951, #15299, #16151

@DerSizeS DerSizeS force-pushed the DerSizeS:fix-ie-input-event branch from 6a5a982 to 562ed76 Apr 17, 2019

@DerSizeS DerSizeS requested a review from angular/fw-integration as a code owner Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.