Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs-infra): add missing ng-conf image #29902

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@gkalpak
Copy link
Member

gkalpak commented Apr 15, 2019

As of b9fead7, the image is referenced in announcements.json, but it was already removed (as it wasn't used at the time) in 7f905da.

fix(docs-infra): add missing ng-conf image
As of b9fead7, the image is referenced in `announcements.json`, but it
was already removed (as it wasn't used at the time) in 7f905da.

@gkalpak gkalpak requested a review from angular/fw-docs-marketing as a code owner Apr 15, 2019

@ngbot ngbot bot added this to the Backlog milestone Apr 15, 2019

@googlebot googlebot added the cla: yes label Apr 15, 2019

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Apr 15, 2019

@gkalpak

This comment has been minimized.

Copy link
Member Author

gkalpak commented Apr 15, 2019

Before
ng-conf-before

After
ng-conf-after

@StephenFluin

This comment has been minimized.

Copy link
Member

StephenFluin commented Apr 15, 2019

Thanks for catching this! I'll need to double check to make sure Connect and Mix have logos still.

@gkalpak

This comment has been minimized.

@alxhub alxhub closed this in d1d0f4a Apr 15, 2019

alxhub added a commit that referenced this pull request Apr 15, 2019

fix(docs-infra): add missing ng-conf image (#29902)
As of b9fead7, the image is referenced in `announcements.json`, but it
was already removed (as it wasn't used at the time) in 7f905da.

PR Close #29902

@gkalpak gkalpak deleted the gkalpak:fix-aio-missing-ngconf-image branch Apr 15, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

fix(docs-infra): add missing ng-conf image (angular#29902)
As of b9fead7, the image is referenced in `announcements.json`, but it
was already removed (as it wasn't used at the time) in 7f905da.

PR Close angular#29902
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.