Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docs-infra): upgrade lighthouse and list missing dependencies #29904

Closed
wants to merge 2 commits into from

Conversation

@gkalpak
Copy link
Member

gkalpak commented Apr 15, 2019

This PR contains two changes:

  1. build(docs-infra): upgrade lighthouse to 4.3.0
    Also, log the Lighthouse version in test-pwa-score to aid in debugging.

  2. build(docs-infra): add missing dependencies (chrome-launcher, lighthouse-logger)
    We are using chrome-launcher and lighthouse-logger in test-pwa-score, but we do not explicitly list them as devDependencies, so we are relying on the fact that they happen to be hoisted in node_modules/ by yarn. This may unexpectedly break in the future.

    This commit fixes this, by explicitly listing them as devDependencies.

gkalpak added some commits Apr 15, 2019

build(docs-infra): upgrade lighthouse to 4.3.0
Also, log the Lighthouse version in `test-pwa-score` to aid in
debugging.
build(docs-infra): add missing dependencies (chrome-launcher, lightho…
…use-logger)

We are using `chrome-launcher` and `lighthouse-logger` in
[test-pwa-score][1], but we do not explicitly list them as
`devDependencies`, so we are relying on the fact that they happen to be
hoisted in `node_modules/` by yarn. This may unexpectedly break in the
future.

This commit fixes this, by explicitly listing them as `devDependencies`.

[1]: https://github.com/angular/angular/blob/ea70d41ac/aio/scripts/test-pwa-score.js#L14-L18
@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Apr 15, 2019

@alxhub alxhub closed this in 4f9c935 Apr 15, 2019

alxhub added a commit that referenced this pull request Apr 15, 2019

build(docs-infra): add missing dependencies (chrome-launcher, lightho…
…use-logger) (#29904)

We are using `chrome-launcher` and `lighthouse-logger` in
[test-pwa-score][1], but we do not explicitly list them as
`devDependencies`, so we are relying on the fact that they happen to be
hoisted in `node_modules/` by yarn. This may unexpectedly break in the
future.

This commit fixes this, by explicitly listing them as `devDependencies`.

[1]: https://github.com/angular/angular/blob/ea70d41ac/aio/scripts/test-pwa-score.js#L14-L18

PR Close #29904

alxhub added a commit that referenced this pull request Apr 15, 2019

build(docs-infra): upgrade lighthouse to 4.3.0 (#29904)
Also, log the Lighthouse version in `test-pwa-score` to aid in
debugging.

PR Close #29904

alxhub added a commit that referenced this pull request Apr 15, 2019

build(docs-infra): add missing dependencies (chrome-launcher, lightho…
…use-logger) (#29904)

We are using `chrome-launcher` and `lighthouse-logger` in
[test-pwa-score][1], but we do not explicitly list them as
`devDependencies`, so we are relying on the fact that they happen to be
hoisted in `node_modules/` by yarn. This may unexpectedly break in the
future.

This commit fixes this, by explicitly listing them as `devDependencies`.

[1]: https://github.com/angular/angular/blob/ea70d41ac/aio/scripts/test-pwa-score.js#L14-L18

PR Close #29904

@gkalpak gkalpak deleted the gkalpak:build-aio-upgrade-lighthouse branch Apr 15, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

build(docs-infra): upgrade lighthouse to 4.3.0 (angular#29904)
Also, log the Lighthouse version in `test-pwa-score` to aid in
debugging.

PR Close angular#29904

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

build(docs-infra): add missing dependencies (chrome-launcher, lightho…
…use-logger) (angular#29904)

We are using `chrome-launcher` and `lighthouse-logger` in
[test-pwa-score][1], but we do not explicitly list them as
`devDependencies`, so we are relying on the fact that they happen to be
hoisted in `node_modules/` by yarn. This may unexpectedly break in the
future.

This commit fixes this, by explicitly listing them as `devDependencies`.

[1]: https://github.com/angular/angular/blob/ea70d41ac/aio/scripts/test-pwa-score.js#L14-L18

PR Close angular#29904

@gkalpak gkalpak added this to IN PROGRESS in docs-infra Apr 18, 2019

@gkalpak gkalpak moved this from IN PROGRESS to MERGE in docs-infra Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.