Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add redirects for deprecated http APIs #29907

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@chembu
Copy link
Contributor

chembu commented Apr 15, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Added redirect links for deprecated http APIs

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@chembu chembu requested a review from angular/docs-infra as a code owner Apr 15, 2019

@googlebot googlebot added the cla: yes label Apr 15, 2019

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Apr 15, 2019

@petebacondarwin
Copy link
Member

petebacondarwin left a comment

I wonder if we really want to direct people for individual files? Without some message explaining what has happened it could be quite confusing. I would have expected to be redirected to a page that explained how to migrate from the old http to the new one.

{"type": 301, "source": "/**/api/http", "destination": "/api/common/http"},
{"type": 301, "source": "/**/api/http/BaseRequestOptions", "destination": "/api/common/http/HttpRequest"},
{"type": 301, "source": "/**/api/http/BaseResponseOptions", "destination": "/api/common/http/HttpResponse"},
{"type": 301, "source": "/**/api/http/BrowserXhr", "destination": "/api/common/http/BrowserXhr"},

This comment has been minimized.

Copy link
@CaerusKaru

CaerusKaru Apr 15, 2019

Member

I know we discussed offline that this would be made public, but other discussions have taken place with @alxhub and @vikerman since then, and that is no longer the case.

@gkalpak
Copy link
Member

gkalpak left a comment

I am not sure how I feel about this. I think I would rather either be redirected to migration docs or to the default 404 page (which shows related search results).

{"type": 301, "source": "/**/api/http/testing/MockBackend", "destination": "/api/common/http/testing/HttpTestingController"},
{"type": 301, "source": "/**/api/http/testing/MockConnection", "destination": "/api/common/http/testing/HttpTestingController"},
{"type": 301, "source": "/**/api/http/testing", "destination": "/api/common/http/testing"},
{"type": 301, "source": "/**/api/http/ReadyState", "destination": "/api/common/http/HttpClient"},

This comment has been minimized.

Copy link
@gkalpak

gkalpak Apr 15, 2019

Member

In order for these to work correctly on subsequent navigations, you also need to update ngsw-config.json > navigationUrls.

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Apr 16, 2019

@chembu chembu force-pushed the chembu:http-redirects branch from a065d75 to 300d999 Apr 17, 2019

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Apr 17, 2019

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Apr 17, 2019

@benlesh benlesh added the comp: docs label Apr 17, 2019

@ngbot ngbot bot added this to the needsTriage milestone Apr 17, 2019

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.