Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docs-infra): update to latest CLI beta #29908

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
5 participants
@gkalpak
Copy link
Member

gkalpak commented Apr 15, 2019

#29764 but for the 7.2.x branch.

@gkalpak gkalpak requested a review from angular/docs-infra as a code owner Apr 15, 2019

@googlebot

This comment has been minimized.

Copy link

googlebot commented Apr 15, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Apr 15, 2019

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Apr 15, 2019

@gkalpak gkalpak force-pushed the gkalpak:7.2.x-cli-webworker branch from 38dcd07 to b0b4de7 Apr 15, 2019

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Apr 15, 2019

@gkalpak gkalpak changed the title 7.2.x cli webworker build(docs-infra): update to latest CLI beta Apr 15, 2019

@ngbot ngbot bot added this to the needsTriage milestone Apr 15, 2019

@ngbot

This comment has been minimized.

Copy link

ngbot bot commented Apr 15, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "cla/google" is failing
    pending missing required labels: cla: yes
    pending forbidden labels detected: cla: no

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@gkalpak

This comment has been minimized.

Copy link
Member Author

gkalpak commented Apr 15, 2019

merge-assistance: Requires manual CLA verification.

@alxhub alxhub added cla: yes and removed cla: no labels Apr 15, 2019

@googlebot

This comment has been minimized.

Copy link

googlebot commented Apr 15, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

alxhub added a commit that referenced this pull request Apr 15, 2019

alxhub added a commit that referenced this pull request Apr 15, 2019

@gkalpak

This comment has been minimized.

Copy link
Member Author

gkalpak commented Apr 15, 2019

Merged as cd2a2f7 and e5cbc9b.

@gkalpak gkalpak closed this Apr 15, 2019

@gkalpak gkalpak deleted the gkalpak:7.2.x-cli-webworker branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.