Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove cc_binary dependency on brotli #29912

Closed
wants to merge 1 commit into from

Conversation

@alexeagle
Copy link
Contributor

alexeagle commented Apr 15, 2019

Just use the JavaScript port instead. We don't care about speed since we compress once as a build step.

@alexeagle alexeagle requested review from IgorMinar and angular/fw-dev-infra as code owners Apr 15, 2019

@googlebot googlebot added the cla: yes label Apr 15, 2019

@alexeagle alexeagle force-pushed the alexeagle:rm_cc_dep branch 2 times, most recently from 0329aea to 13c9984 Apr 15, 2019

@filipesilva
Copy link
Member

filipesilva left a comment

Current errors seem unrelated to the changes in this PR.

The lighthouse score one is #29910, and the integration test one is fixed by angular/angular-cli#14180.

build: Remove cc_binary dependency on brotli
Just use the JavaScript port instead. We don't care about speed since we compress once as a build step.

@alexeagle alexeagle force-pushed the alexeagle:rm_cc_dep branch from 13c9984 to b704fcb Apr 16, 2019

@ngbot ngbot bot added this to the needsTriage milestone Apr 17, 2019

@benlesh

This comment has been minimized.

Copy link
Contributor

benlesh commented Apr 17, 2019

@alexeagle

This comment has been minimized.

Copy link
Contributor Author

alexeagle commented Apr 17, 2019

assist: fails on two already-broken targets

@benlesh

This comment has been minimized.

Copy link
Contributor

benlesh commented Apr 18, 2019

Caretaker note: Merged on @filipesilva's review.

@benlesh benlesh closed this in b9251fd Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.