Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable shard_count for some jasmine tests that have many specs #29913

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@gregmagolan
Copy link
Contributor

gregmagolan commented Apr 15, 2019

Redo of #29196 now that issues with sharding have been resolved in nodejs rules (fixed in nodejs rules 0.27.9).

@gregmagolan

This comment has been minimized.

Copy link
Contributor Author

gregmagolan commented Apr 15, 2019

Blocked on bazelbuild/rules_nodejs#698 and next nodejs release

@gregmagolan

This comment has been minimized.

Copy link
Contributor Author

gregmagolan commented Apr 15, 2019

Screen Shot 2019-04-15 at 1 36 43 PM

Sharding looks like this when running

@gregmagolan

This comment has been minimized.

Copy link
Contributor Author

gregmagolan commented Apr 15, 2019

@alexeagle Should finally be able to enable this after the next nodejs rules release (just merged bazelbuild/rules_nodejs#698).

@ngbot ngbot bot added this to the needsTriage milestone Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.