Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): DebugNode.properties not preserving type of values #29914

Closed

Conversation

Projects
None yet
3 participants
@crisbeto
Copy link
Member

crisbeto commented Apr 15, 2019

Fixes the DebugNode.properties casting all of the values to a string.

This PR resolves FW-1253.

@googlebot googlebot added the cla: yes label Apr 15, 2019

fix(ivy): DebugNode.properties not preserving type of values
Fixes the `DebugNode.properties` casting all of the values to a string.

This PR resolves FW-1253.

@crisbeto crisbeto force-pushed the crisbeto:FW-1253/debug-node-prop-values branch from 497c935 to 106a62d Apr 15, 2019

@crisbeto crisbeto marked this pull request as ready for review Apr 15, 2019

@crisbeto crisbeto requested a review from angular/fw-core as a code owner Apr 15, 2019

@kara

kara approved these changes Apr 15, 2019

Copy link
Contributor

kara left a comment

LGTM

@kara

This comment has been minimized.

Copy link
Contributor

kara commented Apr 15, 2019

@alxhub alxhub closed this in 5d824c4 Apr 16, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

fix(ivy): DebugNode.properties not preserving type of values (angular…
…#29914)

Fixes the `DebugNode.properties` casting all of the values to a string.

This PR resolves FW-1253.

PR Close angular#29914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.