Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixed typo on HttpParamsOptions #29916

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
2 participants
@xjose97x
Copy link

xjose97x commented Apr 15, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This is just a typo fix in the documentation of fromObject property of HttpParamOptions

@xjose97x xjose97x requested a review from angular/fw-http as a code owner Apr 15, 2019

@googlebot

This comment has been minimized.

Copy link

googlebot commented Apr 15, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Apr 15, 2019

@xjose97x

This comment has been minimized.

Copy link
Author

xjose97x commented Apr 15, 2019

I signed it!

@googlebot

This comment has been minimized.

Copy link

googlebot commented Apr 15, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Apr 15, 2019

@xjose97x xjose97x changed the title Fixed typo on HttpParamsOptions docs: Fixed typo on HttpParamsOptions Apr 15, 2019

@xjose97x xjose97x closed this Apr 16, 2019

@xjose97x xjose97x deleted the xjose97x:patch-1 branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.