Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): multi provider override support in TestBed #29919

Conversation

Projects
None yet
3 participants
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Apr 16, 2019

Overriding multi provider values (providers with multi: true flag) via TestBed require additional handling: all existing multi-provider values for the same token should be removed from the override list, so that they are not included into the final value of a given provider. This commit adds this logic to make sure we handle multi providers correctly.

This PR resolves FW-1251.

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No
@kara

kara approved these changes Apr 16, 2019

Copy link
Contributor

kara left a comment

LGTM

@kara kara removed their assignment Apr 16, 2019

@kara

This comment has been minimized.

Copy link
Contributor

kara commented Apr 16, 2019

fix(ivy): multi provider override support in TestBed
Overriding multi provider values (providers with `multi: true` flag) via TestBed require additional handling: all existing multi-provider values for the same token should be removed from the override list, so that they are not included into the final value of a given provider. This commit adds this logic to make sure we handle multi providers correctly.

@AndrewKushnir AndrewKushnir force-pushed the AndrewKushnir:FW-1251_multi_providers_support branch from d6b7f95 to d5aeaa7 Apr 16, 2019

@ngbot

This comment has been minimized.

Copy link

ngbot bot commented Apr 16, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: integration_test" is failing
    pending missing required status "ci/circleci: publish_snapshot"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@kara

This comment has been minimized.

Copy link
Contributor

kara commented Apr 16, 2019

merge-assistance: integration test for size broken on master

@alxhub alxhub closed this in 5f1b637 Apr 16, 2019

wKoza added a commit to wKoza/angular that referenced this pull request Apr 17, 2019

fix(ivy): multi provider override support in TestBed (angular#29919)
Overriding multi provider values (providers with `multi: true` flag) via TestBed require additional handling: all existing multi-provider values for the same token should be removed from the override list, so that they are not included into the final value of a given provider. This commit adds this logic to make sure we handle multi providers correctly.

PR Close angular#29919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.