fix(ivy): coalesced listeners should preventDefault if any returns false #29934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
reviewed
Apr 16, 2019
We had a bug where event.preventDefault() was not always called if listeners were coalesced. This is because we were overwriting the previous listener's result every time we called the next listener, so listeners early in the chain that returned false would be ignored and preventDefault would not be called. This commit fixes that issue, so now preventDefault() is called if any listener in a coalesced chain returns false. This brings us in line with View Engine behavior.
kara
added
comp: ivy
action: review
kara
added
action: merge
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
…lse (angular#29934) We had a bug where event.preventDefault() was not always called if listeners were coalesced. This is because we were overwriting the previous listener's result every time we called the next listener, so listeners early in the chain that returned false would be ignored and preventDefault would not be called. This commit fixes that issue, so now preventDefault() is called if any listener in a coalesced chain returns false. This brings us in line with View Engine behavior. PR Close angular#29934
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bug where event.preventDefault() was not always called if listeners
were coalesced. This is because we were overwriting the previous listener's
result every time we called the next listener, so listeners early in the chain
that returned false would be ignored and preventDefault would not be called.
This commit fixes that issue, so now preventDefault() is called if any listener
in a coalesced chain returns false. This brings us in line with View Engine
behavior.