Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add schematics to move deprecated DOCUMENT import #29950

Closed
wants to merge 4 commits into from

Conversation

@CaerusKaru
Copy link
Member

commented Apr 17, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CaerusKaru CaerusKaru requested review from IgorMinar and angular/fw-core as code owners Apr 17, 2019

@googlebot googlebot added the cla: yes label Apr 17, 2019

@CaerusKaru CaerusKaru force-pushed the CaerusKaru:adam/scm-doc branch from ced7f0a to fd762b1 Apr 17, 2019

@CaerusKaru

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2019

After this is merged, we can finally land #28117

@devversion
Copy link
Member

left a comment

Nice! early review. You mentioned that there is still work pending to use the ts.Printer. Here are some comments (mostly minor nits)

@ngbot ngbot bot added this to the needsTriage milestone Apr 17, 2019

@CaerusKaru CaerusKaru force-pushed the CaerusKaru:adam/scm-doc branch from cd591ec to 1e00a5d Apr 18, 2019

@IgorMinar
Copy link
Member

left a comment

thanks @CaerusKaru!

@IgorMinar

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

merge-assistance: global approval

@benlesh benlesh closed this in 645e305 Apr 22, 2019

@CaerusKaru CaerusKaru deleted the CaerusKaru:adam/scm-doc branch Apr 22, 2019

BioPhoton added a commit to BioPhoton/angular that referenced this pull request May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.