Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): restore ng build --prod #30005

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@kyliau
Copy link
Member

commented Apr 20, 2019

ng build by default builds the prodapp because there is not
a dev build in Bazel. This PR restores the --prod to do the
same to prevent achitect from showing missing config error.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

fix(bazel): restore ng build --prod
`ng build` by default builds the prodapp because there is not
a dev build in Bazel. This PR restores the `--prod` to do the
same to prevent achitect from showing missing config error.

@kyliau kyliau requested a review from angular/tools-bazel as a code owner Apr 20, 2019

@ngbot ngbot bot added this to the needsTriage milestone Apr 20, 2019

@googlebot googlebot added the cla: yes label Apr 20, 2019

@kyliau kyliau requested a review from alexeagle Apr 20, 2019

@mgechev
Copy link
Member

left a comment

Makes sense to me. In general, we should consider producing a production build by default. Since this would be a breaking change, we should plan it for v9 though.

@benlesh benlesh closed this in 96a8289 Apr 22, 2019

@kyliau kyliau deleted the kyliau:build branch Apr 22, 2019

BioPhoton added a commit to BioPhoton/angular that referenced this pull request May 21, 2019

fix(bazel): restore ng build --prod (angular#30005)
`ng build` by default builds the prodapp because there is not
a dev build in Bazel. This PR restores the `--prod` to do the
same to prevent achitect from showing missing config error.

PR Close angular#30005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.