Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service-worker): bypass on queryparam/header (#21191) #30010

Closed
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Prev

fixup! feat(service-worker): support bypassing SW with specific heade…

…r/query param
  • Loading branch information...
gkalpak committed Apr 25, 2019
commit 14994b48a1539b502068b61369f74650d3a474e9
@@ -155,7 +155,7 @@ workers (e.g.
[reporting progress on uploaded files](https://github.com/w3c/ServiceWorker/issues/1141)).

To bypass the service worker you can set `ngsw-bypass` as a request header, or as a query parameter.
(The value of the header or query param is ignored and can be empty or omitted.)
(The value of the header or query parameter is ignored and can be empty or omitted.)

## Debugging the Angular service worker

@@ -740,15 +740,15 @@ import {async_beforeEach, async_fit, async_it} from './async';
await makeRequest(scope, '/bar.txt?ngsw-bypaSS=something');
server.assertNoRequestFor('/bar.txt');

await makeRequest(scope, '/bar.txt?testparam=test&ngsw-bypASS=anything');
await makeRequest(scope, '/bar.txt?testparam=test&ngsw-byPASS=anything');
server.assertNoRequestFor('/bar.txt');

await makeRequest(scope, '/bar.txt?testparam=test&angsw-bypASS=anything');
await makeRequest(scope, '/bar.txt?testparam=test&angsw-byPASS=anything');
server.assertSawRequestFor('/bar.txt');

server.clearRequests();

await makeRequest(scope, '/bar&ngsw-bypass=true.txt?testparam=test&angsw-bypASS=anything');
await makeRequest(scope, '/bar&ngsw-bypass=true.txt?testparam=test&angsw-byPASS=anything');
server.assertSawRequestFor('/bar&ngsw-bypass=true.txt');

server.clearRequests();
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.