Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): Remove tsserverlibrary from rollup globals #30123

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@kyliau
Copy link
Member

commented Apr 25, 2019

This PR removes tsserverlibrary from rollup globals since the symbol
should not appear by the time rollup is invoked. tsserverlibrary is
used for types only, so the import statement should not be emitted by
tsc.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from angular/tools-language-service as a code owner Apr 25, 2019

@ngbot ngbot bot added this to the needsTriage milestone Apr 25, 2019

@googlebot googlebot added the cla: yes label Apr 25, 2019

@kyliau kyliau force-pushed the kyliau:tsserverlib branch from 8e89849 to d920cfb Apr 25, 2019

fix(language-service): Remove tsserverlibrary from rollup globals
This PR removes `tsserverlibrary` from rollup globals since the symbol
should not appear by the time rollup is invoked. `tsserverlibrary` is
used for types only, so the import statement should not be emitted by
tsc.

@kyliau kyliau force-pushed the kyliau:tsserverlib branch from d920cfb to 68bae5c Apr 25, 2019

@kyliau kyliau requested a review from vikerman Apr 25, 2019

AndrewKushnir added a commit that referenced this pull request Apr 26, 2019

fix(language-service): Remove tsserverlibrary from rollup globals (#3…
…0123)

This PR removes `tsserverlibrary` from rollup globals since the symbol
should not appear by the time rollup is invoked. `tsserverlibrary` is
used for types only, so the import statement should not be emitted by
tsc.

PR Close #30123

@kyliau kyliau deleted the kyliau:tsserverlib branch Apr 27, 2019

BioPhoton added a commit to BioPhoton/angular that referenced this pull request May 21, 2019

fix(language-service): Remove tsserverlibrary from rollup globals (an…
…gular#30123)

This PR removes `tsserverlibrary` from rollup globals since the symbol
should not appear by the time rollup is invoked. `tsserverlibrary` is
used for types only, so the import statement should not be emitted by
tsc.

PR Close angular#30123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.