Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(language-service): Implement definitionAndBoundSpan #30125

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@kyliau
Copy link
Member

commented Apr 25, 2019

This PR adds the implementation for definitionAndBoundSpan because
it's now preferred over definition. vscode would send this new request
for Go to definition. As part of this PR the implementation for
definition is refactored and simplified. Goldens for both methods are
checked in.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested review from angular/fw-integration as code owners Apr 25, 2019

@ngbot ngbot bot added this to the needsTriage milestone Apr 25, 2019

@googlebot googlebot added the cla: yes label Apr 25, 2019

@kyliau kyliau force-pushed the kyliau:definitionBoundSpan branch 2 times, most recently from 17d81ad to a638bb6 Apr 25, 2019

feat(language-service): Implement `definitionAndBoundSpan`
This PR adds the implementation for `definitionAndBoundSpan` because
it's now preferred over `definition`. vscode would send this new request
for `Go to definition`. As part of this PR the implementation for
`definition` is refactored and simplified. Goldens for both methods are
checked in.

@kyliau kyliau force-pushed the kyliau:definitionBoundSpan branch from a638bb6 to 5815369 Apr 26, 2019

@kyliau kyliau requested a review from vikerman Apr 26, 2019

BioPhoton added a commit to BioPhoton/angular that referenced this pull request May 21, 2019

feat(language-service): Implement `definitionAndBoundSpan` (angular#3…
…0125)

This PR adds the implementation for `definitionAndBoundSpan` because
it's now preferred over `definition`. vscode would send this new request
for `Go to definition`. As part of this PR the implementation for
`definition` is refactored and simplified. Goldens for both methods are
checked in.

PR Close angular#30125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.