Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): Exclude common/upgrade* in metadata.tsconfig.json #30133

Closed
wants to merge 1 commit into from

Conversation

@kyliau
Copy link
Member

commented Apr 25, 2019

It has a dependency on @angular/upgrade which is not part of the
dependencies in package.json, so postinstall would fail.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from alexeagle Apr 25, 2019

@kyliau kyliau requested a review from angular/tools-bazel as a code owner Apr 25, 2019

@ngbot ngbot bot added this to the needsTriage milestone Apr 25, 2019

@googlebot googlebot added the cla: yes label Apr 25, 2019

@kyliau kyliau force-pushed the kyliau:upgrade branch from 7f9b963 to 8695b34 Apr 26, 2019

@kyliau kyliau requested a review from angular/fw-integration as a code owner Apr 26, 2019

@kyliau kyliau force-pushed the kyliau:upgrade branch from 8695b34 to 200e84e Apr 26, 2019

fix(bazel): Exclude common/upgrade* in metadata.tsconfig.json
It has a dependency on @angular/upgrade which is not part of the
dependencies in package.json, so postinstall would fail.

AndrewKushnir added a commit that referenced this pull request Apr 26, 2019

fix(bazel): Exclude common/upgrade* in metadata.tsconfig.json (#30133)
It has a dependency on @angular/upgrade which is not part of the
dependencies in package.json, so postinstall would fail.

PR Close #30133

BioPhoton added a commit to BioPhoton/angular that referenced this pull request May 21, 2019

fix(bazel): Exclude common/upgrade* in metadata.tsconfig.json (angula…
…r#30133)

It has a dependency on @angular/upgrade which is not part of the
dependencies in package.json, so postinstall would fail.

PR Close angular#30133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.