Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): ensure `history.state` is set in `eager` update mode #30154

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@jasonaden
Copy link
Contributor

commented Apr 26, 2019

Without this change, history.state isn't being set when updating the browser URL in eager update mode.

fix(router): ensure `history.state` is set in `eager` update mode
Without this change, `history.state` isn't being set when updating the browser URL in `eager` update mode.

@jasonaden jasonaden requested a review from angular/fw-router as a code owner Apr 26, 2019

@googlebot googlebot added the cla: yes label Apr 26, 2019

@ngbot ngbot bot added this to the needsTriage milestone Apr 26, 2019

@jasonaden

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

@kara

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

@jasonaden Can you look at the TAP failures here?

@kara kara closed this in b40f6f3 May 6, 2019

kara added a commit that referenced this pull request May 6, 2019

fix(router): ensure `history.state` is set in `eager` update mode (#3…
…0154)

Without this change, `history.state` isn't being set when updating the browser URL in `eager` update mode.

PR Close #30154

BioPhoton added a commit to BioPhoton/angular that referenced this pull request May 21, 2019

fix(router): ensure `history.state` is set in `eager` update mode (an…
…gular#30154)

Without this change, `history.state` isn't being set when updating the browser URL in `eager` update mode.

PR Close angular#30154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.