Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix interpolate identifier in AOT #30243

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@kara
Copy link
Contributor

commented May 2, 2019

This commit fixes a regression introduced in PR 29692 where
the interpolate symbol in View Engine was improperly prefixed
with the ɵɵ that signifies private instructions for Ivy. It
resulted in interpolations of 10+ values not working correctly
in AOT mode. This commit removes the prefix.

(I'm unable to add a good test for AOT given the way VE tests
are set up, but I've added one for JIT).

fix(core): fix interpolate identifier in AOT
This commit fixes a regression introduced in PR 29692 where
the interpolate symbol in View Engine was improperly prefixed
with the ɵɵ that signifies private instructions for Ivy. It
resulted in interpolations of 10+ values not working correctly
in AOT mode. This commit removes the prefix.

@kara kara requested review from angular/fw-compiler as code owners May 2, 2019

@googlebot googlebot added the cla: yes label May 2, 2019

@mhevery

mhevery approved these changes May 2, 2019

@ngbot ngbot bot added this to the needsTriage milestone May 2, 2019

kara added a commit that referenced this pull request May 2, 2019

fix(core): fix interpolate identifier in AOT (#30243)
This commit fixes a regression introduced in PR 29692 where
the interpolate symbol in View Engine was improperly prefixed
with the ɵɵ that signifies private instructions for Ivy. It
resulted in interpolations of 10+ values not working correctly
in AOT mode. This commit removes the prefix.

PR Close #30243

@kara kara closed this in 30d1f29 May 2, 2019

@@ -212,4 +212,22 @@ describe('property instructions', () => {

expect(img.src.indexOf('unsafe:')).toBe(0);
});

it('should handle interpolations with 10+ values', () => {

This comment has been minimized.

Copy link
@sajidali

sajidali May 15, 2019

@kara test description says 10+ values, but only checks for exactly 10 values.

BioPhoton added a commit to BioPhoton/angular that referenced this pull request May 21, 2019

fix(core): fix interpolate identifier in AOT (angular#30243)
This commit fixes a regression introduced in PR 29692 where
the interpolate symbol in View Engine was improperly prefixed
with the ɵɵ that signifies private instructions for Ivy. It
resulted in interpolations of 10+ values not working correctly
in AOT mode. This commit removes the prefix.

PR Close angular#30243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.