Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): static-query migration should not prompt if no queries are used #30254

Closed

Conversation

@devversion
Copy link
Member

commented May 3, 2019

Currently we always prompt when the static-query migration runs. This is not
always needed because some applications do not even use ViewChild or
ContentChild queries and it just causes confusion if developers need to
decide on a migration strategy while there is nothing to migrate.

In order to avoid this confusion, we no longer prompt for a strategy
if there are no queries declared within the project.

References #30224

@CaerusKaru
Copy link
Member

left a comment

LGTM

@kara

kara approved these changes May 8, 2019

Copy link
Contributor

left a comment

LGTM

@kara kara removed their assignment May 8, 2019

@kara

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

@kara

This comment has been minimized.

@kara

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

@devversion Can you rename the commit to fix(core)?

fix(core): static-query migration should not prompt if no queries are…
… used

Currently we always prompt when the static-query migration runs. This is not
always needed because some applications do not even use `ViewChild` or
`ContentChild` queries and it just causes confusion if developers need to
decide on a migration strategy while there is nothing to migrate.

In order to avoid this confusion, we no longer prompt for a strategy
if there are no queries declared within the project.

@devversion devversion force-pushed the devversion:not-prompt-if-no-queries branch from 83f0cc6 to 7056cb5 May 8, 2019

@devversion devversion changed the title refactor(core): static-query migration should not prompt if no queries are used fix(core): static-query migration should not prompt if no queries are used May 8, 2019

@alxhub alxhub closed this in 4c12d74 May 8, 2019

alxhub added a commit that referenced this pull request May 8, 2019

fix(core): static-query migration should not prompt if no queries are…
… used (#30254)

Currently we always prompt when the static-query migration runs. This is not
always needed because some applications do not even use `ViewChild` or
`ContentChild` queries and it just causes confusion if developers need to
decide on a migration strategy while there is nothing to migrate.

In order to avoid this confusion, we no longer prompt for a strategy
if there are no queries declared within the project.

PR Close #30254

BioPhoton added a commit to BioPhoton/angular that referenced this pull request May 21, 2019

fix(core): static-query migration should not prompt if no queries are…
… used (angular#30254)

Currently we always prompt when the static-query migration runs. This is not
always needed because some applications do not even use `ViewChild` or
`ContentChild` queries and it just causes confusion if developers need to
decide on a migration strategy while there is nothing to migrate.

In order to avoid this confusion, we no longer prompt for a strategy
if there are no queries declared within the project.

PR Close angular#30254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.