Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): CSS sanitizer now allows parens in file names #30322

Closed
wants to merge 1 commit into from

Conversation

@benlesh
Copy link
Contributor

commented May 8, 2019

Resolves an issue where images that were created with a name like 'foo (1).png' would not pass CSS url sanitization.

fix(core): CSS sanitizer now allows parens in file names
Resolves an issue where images that were created with a name like `'foo (1).png'` would not pass CSS url sanitization.

@ngbot ngbot bot modified the milestone: needsTriage May 8, 2019

@googlebot googlebot added the cla: yes label May 8, 2019

@benlesh benlesh marked this pull request as ready for review May 8, 2019

@benlesh benlesh requested review from angular/fw-core as code owners May 8, 2019

@mhevery

mhevery approved these changes May 8, 2019

@benlesh

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

@alxhub

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

@alxhub

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

alxhub added a commit that referenced this pull request May 8, 2019

fix(core): CSS sanitizer now allows parens in file names (#30322)
Resolves an issue where images that were created with a name like `'foo (1).png'` would not pass CSS url sanitization.

PR Close #30322

@alxhub alxhub closed this May 8, 2019

alxhub added a commit that referenced this pull request May 8, 2019

fix(core): CSS sanitizer now allows parens in file names (#30322)
Resolves an issue where images that were created with a name like `'foo (1).png'` would not pass CSS url sanitization.

PR Close #30322

alxhub added a commit to alxhub/angular that referenced this pull request May 14, 2019

Revert "fix(core): CSS sanitizer now allows parens in file names (ang…
…ular#30322)"

This reverts commit 728db88.

We're reverting this commit for now, until it can be subjected to a more
thorough security review.

alxhub added a commit that referenced this pull request May 14, 2019

Revert "fix(core): CSS sanitizer now allows parens in file names (#30322
)" (#30463)

This reverts commit 728db88.

We're reverting this commit for now, until it can be subjected to a more
thorough security review.

PR Close #30463

alxhub added a commit that referenced this pull request May 14, 2019

Revert "fix(core): CSS sanitizer now allows parens in file names (#30322
)" (#30463)

This reverts commit 728db88.

We're reverting this commit for now, until it can be subjected to a more
thorough security review.

PR Close #30463

BioPhoton added a commit to BioPhoton/angular that referenced this pull request May 21, 2019

fix(core): CSS sanitizer now allows parens in file names (angular#30322)
Resolves an issue where images that were created with a name like `'foo (1).png'` would not pass CSS url sanitization.

PR Close angular#30322

BioPhoton added a commit to BioPhoton/angular that referenced this pull request May 21, 2019

Revert "fix(core): CSS sanitizer now allows parens in file names (ang…
…ular#30322)" (angular#30463)

This reverts commit 728db88.

We're reverting this commit for now, until it can be subjected to a more
thorough security review.

PR Close angular#30463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.