Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): static-query migration should handle queries on accessors #30327

Closed

Conversation

@devversion
Copy link
Member

commented May 8, 2019

Currently the static-query migration ignores queries declared on getters
or setters as these are not part of a PropertyDeclaration. We need to
handle these queries in order to cover all queries within a given project.

The usage strategy is not able to detect timing for queries on accessors,
so we add a TODO and print a message. The template strategy is able
to detect the proper timing for such queries because it's not dependent
on detecting the usage of the query.

Resolves FW-1215

@kara

kara approved these changes May 8, 2019

Copy link
Contributor

left a comment

LGTM, once test added

@kara

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

devversion added some commits May 8, 2019

fix(core): static-query migration should handle queries on accessors
Currently the static-query migration ignores queries declared on getters
or setters as these are not part of a `PropertyDeclaration`. We need to
handle these queries in order to cover all queries within a given project.

The usage strategy is not able to detect timing for queries on accessors,
so we add a TODO and print a message. The template strategy is able
to detect the proper timing for such queries because it's not dependent
on detecting the usage of the query.

Resolves FW-1215

@devversion devversion force-pushed the devversion:fix/core-handle-accessor-queries branch from 63d2c18 to e7b73f2 May 9, 2019

@devversion

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

@kara Rebased and addressed feedback. Thanks!

@devversion devversion removed their assignment May 9, 2019

alxhub added a commit that referenced this pull request May 9, 2019

fix(core): static-query migration should handle queries on accessors (#…
…30327)

Currently the static-query migration ignores queries declared on getters
or setters as these are not part of a `PropertyDeclaration`. We need to
handle these queries in order to cover all queries within a given project.

The usage strategy is not able to detect timing for queries on accessors,
so we add a TODO and print a message. The template strategy is able
to detect the proper timing for such queries because it's not dependent
on detecting the usage of the query.

Resolves FW-1215

PR Close #30327

@alxhub alxhub closed this in 0ffdb48 May 9, 2019

BioPhoton added a commit to BioPhoton/angular that referenced this pull request May 21, 2019

fix(core): static-query migration should handle queries on accessors (a…
…ngular#30327)

Currently the static-query migration ignores queries declared on getters
or setters as these are not part of a `PropertyDeclaration`. We need to
handle these queries in order to cover all queries within a given project.

The usage strategy is not able to detect timing for queries on accessors,
so we add a TODO and print a message. The template strategy is able
to detect the proper timing for such queries because it's not dependent
on detecting the usage of the query.

Resolves FW-1215

PR Close angular#30327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.