Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): ensure navigations start with the current URL value inca… #30344

Closed
Commits on May 8, 2019
  1. fix(router): ensure navigations start with the current URL value inca…

    jasonaden committed May 8, 2019
    …se redirect is skipped
    
    In some cases where multiple navigations happen to the same URL, the router will not process a given URL. In those cases, we fall into logic that resets state for the next navigation. One piece of this resetting is to set the `browserUrlTree` to the most recent `urlAfterRedirects`i.
    
    However, there was bug in this logic because in some cases the `urlAfterRedirects` is a stale value. This happens any time a URL won't be processed, and the previous URL will also not be processed. This creates unpredictable behavior, not the least of which ends up being a broken `back` button.
    
    This PR kicks off new navigations with the current value the router assumes is in the browser. All the logic around how to handle future navigations is based on this value compared to the current transition, so it's important to kick off all new navigations with the current value so in the edge case described above we don't end up with an old value being set into `browserUrlTree`.
    
    Fixes #30340
    Related to #30160
  2. Revert "Revert "fix(router): fix a problem with router not responding…

    jasonaden committed May 8, 2019
    … to back button (#30160)" (#30320)"
    
    This reverts commit 8ced321.
  3. fixup! fix(router): ensure navigations start with the current URL val…

    jasonaden committed May 8, 2019
    …ue incase redirect is skipped
You can’t perform that action at this time.