Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): pass correct arguments to http_server in Windows #30346

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@alan-agius4
Copy link
Contributor

commented May 9, 2019

Under Windows, the server binary has an extension of .exe and the current logic is not handling that.

Partially addresses: #29785

@alan-agius4 alan-agius4 requested review from angular/fw-integration as code owners May 9, 2019

@googlebot googlebot added the cla: yes label May 9, 2019

@ngbot ngbot bot added this to the needsTriage milestone May 9, 2019

@alan-agius4 alan-agius4 force-pushed the alan-agius4:protoactor-bazel branch from 946b861 to 078e2d6 May 9, 2019

fix(bazel): pass correct arguments to http_server in Windows
Under Windows, the server binary has an extension of  `.exe` and the current logic is not handling that.

Partially addresses: #29785

@alan-agius4 alan-agius4 force-pushed the alan-agius4:protoactor-bazel branch from 078e2d6 to c3db1eb May 9, 2019

@kyliau

kyliau approved these changes May 9, 2019

alxhub added a commit that referenced this pull request May 9, 2019

fix(bazel): pass correct arguments to http_server in Windows (#30346)
Under Windows, the server binary has an extension of  `.exe` and the current logic is not handling that.

Partially addresses: #29785

PR Close #30346

@alxhub alxhub closed this in 3aff79c May 9, 2019

BioPhoton added a commit to BioPhoton/angular that referenced this pull request May 21, 2019

fix(bazel): pass correct arguments to http_server in Windows (angular…
…#30346)

Under Windows, the server binary has an extension of  `.exe` and the current logic is not handling that.

Partially addresses: angular#29785

PR Close angular#30346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.