Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): IE 11 bug can break URL unification when comparing objects #30393

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@jasonaden
Copy link
Contributor

commented May 10, 2019

This PR fixes an issue where IE 11 can return undefined in with an Object.keys call. Solution is to add a runtime check on the value. Based on the types being passed, this shouldn't be necessary, but is needed only for IE 11. Unit test doesn't work for this PR because it can't be replicated easily.

@jasonaden jasonaden requested a review from angular/fw-router as a code owner May 10, 2019

@googlebot googlebot added the cla: yes label May 10, 2019

@alxhub alxhub added the comp: router label May 10, 2019

@ngbot ngbot bot added this to the needsTriage milestone May 10, 2019

fix(router): IE 11 bug can break URL unification when comparing objects
This PR fixes an issue where IE 11 can return `undefined` in with an `Object.keys` call. Solution is to add a runtime check on the value. Based on the types being passed, this shouldn't be necessary, but is needed only for IE 11. Unit test doesn't work for this PR because it can't be replicated easily.
@alxhub

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

@alxhub

alxhub approved these changes May 13, 2019

alxhub added a commit that referenced this pull request May 13, 2019

fix(router): IE 11 bug can break URL unification when comparing objec…
…ts (#30393)

This PR fixes an issue where IE 11 can return `undefined` in with an `Object.keys` call. Solution is to add a runtime check on the value. Based on the types being passed, this shouldn't be necessary, but is needed only for IE 11. Unit test doesn't work for this PR because it can't be replicated easily.

PR Close #30393

@alxhub alxhub closed this in 197584d May 13, 2019

@thorn0

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

Where can I learn more about this IE bug? I can't find anything about it anywhere.

jasonaden added a commit to jasonaden/angular that referenced this pull request May 14, 2019

fix(router): type cast correctly for IE 11 bug breaking URL Unificati…
…on when comparing objects

PR angular#30393 corrected behavior where Object.keys sometimes returns an `undefined` value. However, the types didn't reflect this in the code. That fix actually missed one value that could return `undefined`. This PR corrects this by casting the types to what they can be in IE 11. This ensures the code behaves as it should when this edge case comes up.

jasonaden added a commit that referenced this pull request May 15, 2019

fix(router): type cast correctly for IE 11 bug breaking URL Unificati…
…on when comparing objects (#30464)

PR #30393 corrected behavior where Object.keys sometimes returns an `undefined` value. However, the types didn't reflect this in the code. That fix actually missed one value that could return `undefined`. This PR corrects this by casting the types to what they can be in IE 11. This ensures the code behaves as it should when this edge case comes up.

PR Close #30464

jasonaden added a commit that referenced this pull request May 15, 2019

fix(router): type cast correctly for IE 11 bug breaking URL Unificati…
…on when comparing objects (#30464)

PR #30393 corrected behavior where Object.keys sometimes returns an `undefined` value. However, the types didn't reflect this in the code. That fix actually missed one value that could return `undefined`. This PR corrects this by casting the types to what they can be in IE 11. This ensures the code behaves as it should when this edge case comes up.

PR Close #30464

BioPhoton added a commit to BioPhoton/angular that referenced this pull request May 21, 2019

fix(router): IE 11 bug can break URL unification when comparing objec…
…ts (angular#30393)

This PR fixes an issue where IE 11 can return `undefined` in with an `Object.keys` call. Solution is to add a runtime check on the value. Based on the types being passed, this shouldn't be necessary, but is needed only for IE 11. Unit test doesn't work for this PR because it can't be replicated easily.

PR Close angular#30393

BioPhoton added a commit to BioPhoton/angular that referenced this pull request May 21, 2019

fix(router): type cast correctly for IE 11 bug breaking URL Unificati…
…on when comparing objects (angular#30464)

PR angular#30393 corrected behavior where Object.keys sometimes returns an `undefined` value. However, the types didn't reflect this in the code. That fix actually missed one value that could return `undefined`. This PR corrects this by casting the types to what they can be in IE 11. This ensures the code behaves as it should when this edge case comes up.

PR Close angular#30464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.